Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor!: target es2020 #848

Merged
merged 7 commits into from
May 4, 2022
Merged

refactor!: target es2020 #848

merged 7 commits into from
May 4, 2022

Conversation

Shinigami92
Copy link
Member

@Shinigami92 Shinigami92 commented Apr 20, 2022

Together with #847 according to this table https://kangax.github.io/compat-table/es2016plus/#node14_0 I think we can also switch to target 2020 🥳

@Shinigami92 Shinigami92 added p: 1-normal Nothing urgent c: refactor PR that affects the runtime behavior, but doesn't add new features or fixes bugs labels Apr 20, 2022
@Shinigami92 Shinigami92 added this to the v7 - Next Major milestone Apr 20, 2022
@Shinigami92 Shinigami92 self-assigned this Apr 20, 2022
@Shinigami92 Shinigami92 added the s: on hold Blocked by something or frozen to avoid conflicts label Apr 20, 2022
@codecov
Copy link

codecov bot commented May 3, 2022

Codecov Report

Merging #848 (f12ec62) into main (683ee34) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #848   +/-   ##
=======================================
  Coverage   99.67%   99.67%           
=======================================
  Files        1957     1957           
  Lines      209770   209770           
  Branches      877      878    +1     
=======================================
+ Hits       209081   209084    +3     
+ Misses        669      666    -3     
  Partials       20       20           
Impacted Files Coverage Δ
src/modules/finance/index.ts 100.00% <0.00%> (+0.68%) ⬆️

@Shinigami92 Shinigami92 marked this pull request as ready for review May 3, 2022 19:30
@Shinigami92 Shinigami92 requested a review from a team as a code owner May 3, 2022 19:30
@Shinigami92 Shinigami92 changed the title refactor: target es2020 refactor!: target es2020 May 3, 2022
@Shinigami92 Shinigami92 requested a review from a team May 3, 2022 19:38
@Shinigami92 Shinigami92 added s: accepted Accepted feature / Confirmed bug and removed s: on hold Blocked by something or frozen to avoid conflicts labels May 3, 2022
@Shinigami92 Shinigami92 requested review from a team and pkuczynski May 4, 2022 06:14
@ST-DDT ST-DDT requested a review from a team May 4, 2022 10:08
@Shinigami92 Shinigami92 merged commit 63f6361 into main May 4, 2022
@Shinigami92 Shinigami92 deleted the target-es2020 branch May 4, 2022 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: refactor PR that affects the runtime behavior, but doesn't add new features or fixes bugs p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants